feat: Be explicit about span vs resource attributes #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersliland
force-pushed
the
document-span-attributes
branch
from
776ab9e to
68e2f40
Compare
gbbirkisson
reviewed
Jan 12, 2024
| @@ -13,15 +13,15 @@ def configure_tracer( | |||
| enabled: bool, | |||
| endpoint: str, | |||
| service_name: str, | |||
| service_attributes: dict[str, Any] | None = None, | |||
| resource_attributes: dict[str, Any] | None = None, | |||
There was a problem hiding this comment.
This will break the api, so we need to do a major release for this change. I like that the api will be consistent with the visualization in grafana.
There was a problem hiding this comment.
I will probably also use the opportunity to make other minor breaking api changes before we release.
There was a problem hiding this comment.
Yes
Can we add span attribute as a argument somewhere as well.
Hiding the ddtrace set tags config?
There was a problem hiding this comment.
Experience has showed that wrapping the ddtrace api is not popular. So I would just let it be :)
gbbirkisson
approved these changes
Jan 15, 2024
gbbirkisson
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change.
Be explicit about span vs resource attributes and update docs.
https://grafana.com/docs/tempo/latest/operations/best-practices/#span-and-resource-attributes
https://opentelemetry.io/docs/specs/otel/overview/#resources