Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let users control the disable_existing_loggers flag #215

Merged
merged 1 commit into from
Oct 31, 2023
Merged

Let users control the disable_existing_loggers flag #215

merged 1 commit into from
Oct 31, 2023

Conversation

eirsyl
Copy link
Member

@eirsyl eirsyl commented Oct 31, 2023

This is needed to let users not reset the default Django loggers as an example. We needed to opt out of configure_structlog in login.oda.com since it didn't let us keep the default django logs.

gbbirkisson
gbbirkisson approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@gbbirkisson gbbirkisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@eirsyl eirsyl merged commit a955c8f into main Oct 31, 2023
6 checks passed
@eirsyl eirsyl deleted the sylliaas/disable_existing_loggers_flag branch October 31, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbirkisson gbbirkisson gbbirkisson approved these changes

@kiloreven kiloreven Awaiting requested review from kiloreven kiloreven is a code owner

Assignees

@eirsyl eirsyl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eirsyl @gbbirkisson