Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PactPayload types #37

Merged
merged 2 commits into from
Sep 29, 2022
Merged

PactPayload types #37

merged 2 commits into from
Sep 29, 2022

Conversation

CristhianRodriguezMolina
Copy link
Contributor

@CristhianRodriguezMolina CristhianRodriguezMolina commented Sep 29, 2022 •
edited
Loading

Description

Fixes #34

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@CristhianRodriguezMolina @boterop
Created ContPayload, ExecPayload and PactPayload with tests
ad60188 
Co-authored-by: Santiago Botero <98826652+santiagoboterokommit@users.noreply.github.com>
@CristhianRodriguezMolina CristhianRodriguezMolina linked an issue Sep 29, 2022 that may be closed by this pull request
PactPayload types #34
Closed
3 tasks
@CristhianRodriguezMolina CristhianRodriguezMolina marked this pull request as ready for review September 29, 2022 15:56
juanhurtado10
juanhurtado10 suggested changes Sep 29, 2022
View reviewed changes
lib/types/cont_payload.ex Outdated Show resolved Hide resolved
lib/types/cont_payload.ex Outdated Show resolved Hide resolved
@CristhianRodriguezMolina CristhianRodriguezMolina deleted the 34-pact-payload-types branch September 29, 2022 19:06
miguelnietoa pushed a commit that referenced this pull request Oct 11, 2022
@CristhianRodriguezMolina @boterop @miguelnietoa
PactPayload types (#37)
5274776 
* Created ContPayload, ExecPayload and PactPayload with tests

Co-authored-by: Santiago Botero <98826652+santiagoboterokommit@users.noreply.github.com>

* Refactored validation functions

Co-authored-by: Santiago Botero <98826652+santiagoboterokommit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanhurtado10 juanhurtado10 juanhurtado10 approved these changes

Assignees

@CristhianRodriguezMolina CristhianRodriguezMolina

@boterop boterop

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PactPayload types
3 participants
@CristhianRodriguezMolina @juanhurtado10 @boterop