Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add endpoint get_version_info #157

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Add endpoint get_version_info #157

merged 1 commit into from
Jul 18, 2024

Conversation

einerzg
Copy link
Contributor

@einerzg einerzg commented Jul 17, 2024 •
edited by L-Zuluaga
Loading

Description

The endpoint get_version_info was added to get the version information about the RPC and Captive core

Fixes #159

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@einerzg einerzg requested a review from L-Zuluaga July 17, 2024 14:33
@L-Zuluaga L-Zuluaga linked an issue Jul 17, 2024 that may be closed by this pull request
Create the getVersionInfo endpoint #159
Closed
3 tasks
L-Zuluaga
L-Zuluaga approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on this, everything looks good to me 🚀

@einerzg einerzg merged commit bcd1fd3 into kommitters:v0.21 Jul 18, 2024
2 checks passed
einerzg added a commit that referenced this pull request Jul 24, 2024
@einerzg
Release v0.21 (#169)
a352507 
* Add endpoint get_version_info (#157)

* Add state_changes in Simulate Transaction response (#164)

* Add state_changes in Simulate Transaction response

* Add nil option in for state_changes property

* Add endpoint get transaction (#165)

* Add endpoint get transactions

* Add tests and improve the code

* Add readme documentation

* Add TransactionsPayload in the params for endpoint spec

* Add endpoint get fee stats (#166)

* Add endpoint getFeedStats

* Add tests for get fee stats

* Add readme section for getFeeStats

* Fix typo (#167)

* Add prerelease v0.21.0 (#168)

* Add prerelease v0.21.0

* Update the release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L-Zuluaga L-Zuluaga L-Zuluaga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create the getVersionInfo endpoint
2 participants
@einerzg @L-Zuluaga