-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BumpFootprintExpiration operation #323
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>
Co-authored-by: David Roldán <Odraxs@users.noreply.github.com>
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>
miguelnietoa
requested changes
Aug 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Odraxs @EdwinGuayacan comments added
Co-authored-by: Edwin Steven Guayacan <EdwinGuayacan@users.noreply.github.com>
Odraxs
force-pushed
the
314-bump-footprint-op
branch
from
August 3, 2023 16:28
7d2c913
to
12d933a
Compare
miguelnietoa
requested changes
Aug 3, 2023
miguelnietoa
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
To execute this operation and the
RestoreFootprint
op it was needed the files that allow building aSorobanTransactionData
were before sending it to thesimulate_transaction
endpoint in addition to theBumpFootprintExpiration
module for this pr.Closes #314