Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ability to use different codecs for different messages but same client #200

Closed
komuw opened this issue Mar 26, 2020 · 2 comments · Fixed by #201
Closed

ability to use different codecs for different messages but same client #200

komuw opened this issue Mar 26, 2020 · 2 comments · Fixed by #201

Comments

@komuw
Copy link
Owner

komuw commented Mar 26, 2020 •
edited
Loading

right now, the codec is a property of the naz client.

That hinders the ability to use same client to send differently encoded messages
@komuw
Copy link
Owner Author

komuw commented Mar 26, 2020

This comment:
I think that data_coding field is property of short_message, not client - #188 (comment)

was right

@komuw
Copy link
Owner Author

komuw commented Mar 26, 2020

This will be a bit like a continuation of: #193

@komuw komuw changed the title ability to use different codecs per message ability to use different codecs for different messages but same client Apr 26, 2020
@komuw komuw mentioned this issue Apr 26, 2020
Merged
komuw added a commit that referenced this issue Apr 29, 2020
@komuw
Issues/200: add ability to use different codecs for different message…
52e89b9 
…s but for the same client (#201)

What:
- Add ability to use different codecs for different messages while using the same `naz` client.   
  With this change, message encoding is now a property of the message and not the client.

Why:
- Fixes: #200
- It makes more sense for encoding to be a property of message and not client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@komuw