Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/101: fix logging #105

Merged
merged 9 commits into from
May 26, 2019
Merged

Issues/101: fix logging #105

merged 9 commits into from
May 26, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented May 26, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • Fix a number of logging issues like;
    • like adding timestamp to logs
    • accepting NOTSET as a logging level
  • while at it, simplify the token-bucket rate limiting algorithm

Why(Why did you change it?)

References:

@codecov-io
Copy link

codecov-io commented May 26, 2019

Codecov Report

Merging #105 into master will increase coverage by 0.15%.
The diff coverage is 91.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #105      +/-   ##
=========================================
+ Coverage   86.05%   86.2%   +0.15%     
=========================================
  Files          12      12              
  Lines        1018    1044      +26     
=========================================
+ Hits          876     900      +24     
- Misses        142     144       +2
Impacted Files Coverage Δ
naz/__version__.py 100% <ø> (ø) ⬆️
naz/hooks.py 84.21% <ø> (ø) ⬆️
naz/ratelimiter.py 97.14% <100%> (ø) ⬆️
cli/cli.py 68.06% <100%> (ø) ⬆️
naz/client.py 82.03% <100%> (ø) ⬆️
naz/logger.py 93.54% <89.18%> (-0.9%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3115134...2802033. Read the comment docs.

@komuw komuw merged commit e7e48ad into master May 26, 2019
@komuw komuw deleted the issues/101 branch May 26, 2019 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix naz logger
2 participants