Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add benchmark results + issues/140 #141

Merged
merged 19 commits into from
Jun 15, 2019
Merged

add benchmark results + issues/140 #141

merged 19 commits into from
Jun 15, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 13, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • Add benchmark results
  • renamed connection_timeout to socket_timeout

Why(Why did you change it?)

References:

@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #141 into master will decrease coverage by 0.11%.
The diff coverage is 61.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
- Coverage   86.55%   86.44%   -0.12%     
==========================================
  Files          14       14              
  Lines        1272     1276       +4     
==========================================
+ Hits         1101     1103       +2     
- Misses        171      173       +2
Impacted Files Coverage Δ
naz/client.py 80.18% <61.11%> (-0.19%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 321dbdd...6c6b4b5. Read the comment docs.

@komuw komuw changed the title Mem results add benchmark results + issues/140 Jun 15, 2019
@komuw komuw merged commit 13911fb into master Jun 15, 2019
@komuw komuw deleted the mem-results branch June 15, 2019 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handle all socket timeouts
2 participants