Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issues/138:: add pytype analysis #148

Merged
merged 9 commits into from
Jun 22, 2019
Merged

issues/138:: add pytype analysis #148

merged 9 commits into from
Jun 22, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Jun 22, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

  • added static analysis support using pytype

Why(Why did you change it?)

References:

@codecov-io
Copy link

codecov-io commented Jun 22, 2019

Codecov Report

Merging #148 into master will not change coverage.
The diff coverage is 80%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #148   +/-   ##
=======================================
  Coverage   86.33%   86.33%           
=======================================
  Files          14       14           
  Lines        1295     1295           
=======================================
  Hits         1118     1118           
  Misses        177      177
Impacted Files Coverage Δ
naz/__version__.py 100% <ø> (ø) ⬆️
naz/hooks.py 79.16% <0%> (ø) ⬆️
naz/logger.py 90.9% <100%> (ø) ⬆️
naz/nazcodec.py 95.6% <100%> (ø) ⬆️
naz/client.py 80.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 228b302...65133c8. Read the comment docs.

@komuw komuw merged commit 5ed7a05 into master Jun 22, 2019
@komuw komuw deleted the issues/138 branch June 22, 2019 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add pytype analysis, maybe?
2 participants