Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read exactly the entire 16bytes smpp header #155

Merged
merged 11 commits into from
Aug 31, 2019
Merged

Read exactly the entire 16bytes smpp header #155

merged 11 commits into from
Aug 31, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Aug 29, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributor offers to license certain software (a “Contribution” or multiple
“Contributions”) to naz, and naz agrees to accept said Contributions,
under the terms of the MIT License.
Contributor understands and agrees that naz shall have the irrevocable and perpetual right to make
and distribute copies of any Contribution, as well as to create and distribute collective works and
derivative works of any Contribution, under the MIT License.

Now,

What(What have you changed?)

Why(Why did you change it?)

References:

  1. https://github.com/fiorix/go-smpp/blob/6dbf72b9bcea72cea4a035e3a2fc434c4dabaae7/smpp/pdu/header.go#L67-L73

@codecov-io
Copy link

codecov-io commented Aug 29, 2019

Codecov Report

Merging #155 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   86.23%   86.43%   +0.19%     
==========================================
  Files          14       14              
  Lines        1308     1312       +4     
==========================================
+ Hits         1128     1134       +6     
+ Misses        180      178       -2
Impacted Files Coverage Δ
naz/__version__.py 100% <ø> (ø) ⬆️
naz/client.py 80.59% <100%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c803f14...70a7165. Read the comment docs.

@komuw
Copy link
Owner Author

komuw commented Aug 29, 2019

@komuw komuw changed the title Read exactly Read exactly the entire 16bytes smpp header Aug 31, 2019
@komuw komuw merged commit 38de64b into master Aug 31, 2019
@komuw komuw deleted the readExactly branch August 31, 2019 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants