Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-run benchmarks #182

Merged
merged 82 commits into from
Nov 27, 2019
Merged

Re-run benchmarks #182

merged 82 commits into from
Nov 27, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Nov 25, 2019

Thank you for contributing to naz.
Every contribution to naz is important.

Contributions are under the MIT License.

Answer the following questions,

What(What have you changed?)

  • Re-run benchmarks

Why(Why did you change it?)

  • Make sure that no regressions have been introduced

References:

Comment on lines +96 to +98
if self._nameToLevel(level) >= logging.ERROR:
kwargs.update(dict(exc_info=True))

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes a regression caused by the PR: #181

@komuw komuw changed the title Benchmarks ii Re-run benchmarks Nov 26, 2019
@komuw komuw merged commit c47f503 into master Nov 27, 2019
@komuw komuw deleted the benchmarksII branch November 27, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant