Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few ergonomic fixes #191

Merged
merged 51 commits into from
Dec 5, 2019
Merged

A few ergonomic fixes #191

merged 51 commits into from
Dec 5, 2019

Conversation

komuw
Copy link
Owner

@komuw komuw commented Dec 5, 2019 •
edited
Loading

Thank you for contributing to naz.
Every contribution to naz is important.

Contributions are under the MIT License.

Answer the following questions,

What(What have you changed?)

  • Rename naz.nazcodec.BaseNazCodec to naz.codec.BaseCodec
  • Rename naz.Client.codec_class to naz.Client.codec
  • Add ability for naz.log.SimpleLogger to render logs as a python dictionary
  • run mypy and pytype in benchmarks/ and examples/ directory

Why(Why did you change it?)

  • Better ergonomics
  • Better debugging

References:

@komuw komuw changed the title Fixes A few ergonomic fixes Dec 5, 2019
@komuw komuw merged commit cc6ce64 into master Dec 5, 2019
@komuw komuw deleted the fixes branch December 5, 2019 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@komuw