Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/199: support Smpp Optional Tags in submit_sm #202

Merged
merged 56 commits into from
May 31, 2020
Merged

Conversation

komuw
Copy link
Owner

@komuw komuw commented Apr 30, 2020

Thank you for contributing to naz.
Every contribution to naz is important.

Contributions are under the MIT License.

Answer the following questions,

What(What have you changed?)

  • Support Smpp Optional Tags in submit_sm

Why(Why did you change it?)

References:

@komuw komuw changed the title Issues/199 Issues/199: support Smpp Optional Tags in submit_sm May 29, 2020
@codecov-commenter
Copy link

codecov-commenter commented May 30, 2020

Codecov Report

Merging #202 into master will decrease coverage by 0.12%.
The diff coverage is 67.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #202      +/-   ##
==========================================
- Coverage   84.72%   84.60%   -0.13%     
==========================================
  Files          15       15              
  Lines        1532     1565      +33     
==========================================
+ Hits         1298     1324      +26     
- Misses        234      241       +7     
Impacted Files Coverage Δ
naz/codec.py 97.91% <ø> (ø)
naz/state.py 87.93% <55.55%> (-12.07%) ⬇️
naz/client.py 80.99% <85.71%> (+0.23%) ⬆️
naz/protocol.py 82.06% <93.75%> (+11.82%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aafd160...8668f5a. Read the comment docs.

@komuw komuw marked this pull request as ready for review May 31, 2020 05:56
@komuw komuw mentioned this pull request May 31, 2020
@komuw komuw merged commit ee516fa into master May 31, 2020
@komuw komuw deleted the issues/199 branch May 31, 2020 06:39
@komuw komuw restored the issues/199 branch May 31, 2020 06:40
komuw added a commit that referenced this pull request May 31, 2020
What
- Update documentation

Why:
- In #202, we added support for optional params in `submit_sm`; this is the PR to update documentation for that previoos PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for Smpp Optional Tags
2 participants