Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.8.0: When unbinding and disconnecting from SMSC, set SMPP session state to CLOSED #213

Closed
wants to merge 8 commits into from

Conversation

komuw
Copy link
Owner

@komuw komuw commented Sep 18, 2020

Thank you for contributing to naz.
Every contribution to naz is important.

Contributions are under the MIT License.

Answer the following questions,

What(What have you changed?)

  • When unbinding and disconnecting from SMSC, set SMPP session state to CLOSED
  • add a test to check that; during shutdown we close the writer & not reader

Why(Why did you change it?)

References:

@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2020

Codecov Report

Merging #213 into master will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #213      +/-   ##
==========================================
+ Coverage   84.59%   84.82%   +0.23%     
==========================================
  Files          15       15              
  Lines        1564     1568       +4     
==========================================
+ Hits         1323     1330       +7     
+ Misses        241      238       -3     
Impacted Files Coverage Δ
naz/client.py 81.53% <100.00%> (+0.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ccc848...c4244ad. Read the comment docs.

@komuw komuw changed the title Release/0.8.0 Release/0.8.0: When unbinding and disconetting from SMSC, set SMPP session state to CLOSED Sep 18, 2020
@komuw komuw changed the title Release/0.8.0: When unbinding and disconetting from SMSC, set SMPP session state to CLOSED Release/0.8.0: When unbinding and disconnecting from SMSC, set SMPP session state to CLOSED Sep 18, 2020
@komuw komuw marked this pull request as ready for review September 19, 2020 16:31
@komuw
Copy link
Owner Author

komuw commented Sep 19, 2020

superseded by #214

@komuw komuw closed this Sep 19, 2020
@komuw komuw deleted the release/0.8.0 branch September 19, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants