Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADR027] Add Container Image Process #104

Merged
merged 6 commits into from
Aug 14, 2023
Merged

Conversation

kim-tsao
Copy link
Contributor

Add a new Container Image Process to address https://issues.redhat.com/browse/RHTAP-827

@arewm arewm requested review from ralphbean, amfred and arewm May 31, 2023 14:23
ADR/0025-container-images.md Outdated Show resolved Hide resolved
ADR/0025-container-images.md Outdated Show resolved Hide resolved
### Scope
* The scope of this process is limited to the images found in our [quay.io/organization/redhat-appstudio](https://quay.io/organization/redhat-appstudio) repository.
* Images from dependencies that fall outside of this AppStudio process should follow the ESS SEC-PATCH-REQ-1 and ESS SEC-PATCH-REQ-2 processes. It is up to the component teams to ensure they are adhering to these requirements.
* Images that are not intended for the staging and/or production environments are out of scope.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you clarify this? Are you just trying to say something to the effect that EC-based decisions for use in generic workloads are out of scope (like internal productization)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For point 3, I was trying to say it's out of scope for dev and test environments. For point 2, we may also pick up images from 3rd party dependencies that are not built using PaC but we should also ensure they are low risk by following the ESS guidelines

ADR/0025-container-images.md Outdated Show resolved Hide resolved
ADR/0025-container-images.md Outdated Show resolved Hide resolved
ADR/0025-container-images.md Outdated Show resolved Hide resolved
ADR/0025-container-images.md Outdated Show resolved Hide resolved
ADR/0025-container-images.md Outdated Show resolved Hide resolved
ADR/0025-container-images.md Outdated Show resolved Hide resolved
The purpose of this document is to establish container image management practices for AppStudio container images that are deployed in the staging and production environments. The goal is to ensure that AppStudio is continuously maintaining secure operations that are in accordance with the ESS SEC-PATCH-REQ-2 (OS Patching) requirements.

### Scope
* The scope of this process is limited to the images found in our [quay.io/organization/redhat-appstudio](https://quay.io/organization/redhat-appstudio) repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images produced via the build platform will not be pushed to this organization by default. How will images get pushed there? Will there be a required release pipeline process for them to follow to get the images mirrored?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Instructions have been pretty vague or word of mouth. The only instructions I know of are to follow https://redhat-appstudio.github.io/infra-deployments/docs/deployment/extending-the-service.html, copy over the tekton yamls from some other component which and customize them. I don't know if there are better instructions anywhere else that I can link to.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we get another issue opened so someone can write up instructions that we can link to from this ADR?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a related conversation happening now about this process. Maybe we can combine/unify the two threads.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any update on this thread?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on PTO when the conversation happened, so I don't know much about what was discussed. We can consider accepting what's currently written and update this ADR when there's more info

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just requested a review on this PR from @sbose78 and @scoheb on this document as they have been involved in the effort to build using the platform.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbose78 and @scoheb I'm going to merge this but can you submit a PR to update it if you have later/better information to add?

@kim-tsao kim-tsao changed the title Add Container Image Process [ADR025] Add Container Image Process Jun 19, 2023
kim-tsao added 2 commits June 30, 2023 16:28
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
kim-tsao added 2 commits June 30, 2023 17:45
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Signed-off-by: Kim Tsao <ktsao@redhat.com>
Co-authored-by: Ralph Bean <rbean@redhat.com>
@kim-tsao kim-tsao changed the title [ADR025] Add Container Image Process [ADR027] Add Container Image Process Aug 9, 2023
Signed-off-by: Kim Tsao <ktsao@redhat.com>
@arewm arewm requested review from sbose78 and scoheb August 11, 2023 15:23
@amfred
Copy link
Contributor

amfred commented Aug 14, 2023

Thank you for the write-up. I recommend publishing these and then updating them as needed.

@amfred amfred merged commit e7ba3ee into konflux-ci:main Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants