Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added slide url to detail page #310

Merged
merged 1 commit into from
Feb 21, 2016
Merged

Added slide url to detail page #310

merged 1 commit into from
Feb 21, 2016

Conversation

konifar
Copy link
Owner

@konifar konifar commented Feb 20, 2016

Thanks to @jmatsu. #308

Added slide url link if it exists.

2016-02-20_07_22_05_png_and_downloads

slide section is not shown if it does not exist.

2016-02-20_07_21_57_png_and_

@hotchemi
Copy link
Contributor

Just one suggestion, how about using HTML technique? Sometimes url link tends to be long.

<string name="link"><![CDATA[<a href-"slide link">Link</a>]]></string>
setText(Html.fromHtml(getString(R.string.link));

@konifar
Copy link
Owner Author

konifar commented Feb 20, 2016

Good suggestion!
But I can not decide what is the best link word. Link or {Session title} or image icon...
So I think a little bit more!

@hotchemi
Copy link
Contributor

Thx! There is no deadline so please take your time.
And I found we can use this icon:) https://design.google.com/icons/#ic_public

@konifar
Copy link
Owner Author

konifar commented Feb 21, 2016

Sorry, I can't find good icon... And I guess url link is better than replaced link word.
Of course I want to change if some good solution is found.
How do you think?

@hotchemi
Copy link
Contributor

OK, IMP public icon is not bad but this is your app! I definitely have respect for your opinion. Thank you.

@konifar
Copy link
Owner Author

konifar commented Feb 21, 2016

Thanks! 🙇

konifar added a commit that referenced this pull request Feb 21, 2016
@konifar konifar merged commit 264dbd5 into master Feb 21, 2016
@konifar konifar deleted the add_share_link_to_detail branch February 21, 2016 03:39
@konifar konifar added this to the 1.1.4 milestone Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants