🐛 Don't use full konveyor.Dep for dependency Extras #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavgaikwad
changed the title
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
|
PR looks good, just for my curiosity, is it right understanding that the |
|
@aufi Not all complex fields are a problem only a certain fields that make grpc protobuf / json / yaml marshaling get confused on some nested fields. In this case, labels []string was being an issue |
pranavgaikwad
requested changes
Apr 5, 2024
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
aufi
approved these changes
Apr 5, 2024
pranavgaikwad
approved these changes
Apr 5, 2024
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
pranavgaikwad
pushed a commit
to pranavgaikwad/analyzer-lsp
that referenced
this pull request
Apr 8, 2024
Signed-off-by: Emily McMullan <emcmulla@redhat.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.