-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add rules for annotation inspection queries on location ANNOTATION #683
Merged
jmle
merged 7 commits into
konveyor:main
from
jmle:annotation-inspection-on-annotations
Sep 25, 2024
Merged
🐛 Add rules for annotation inspection queries on location ANNOTATION #683
jmle
merged 7 commits into
konveyor:main
from
jmle:annotation-inspection-on-annotations
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jmle
commented
Jul 30, 2024
•
edited by djzager
Loading
edited by djzager
- Fixes [BUG] Annotation location cannot be inspected for attributes/parameters #655
jmle
changed the title
Add rules for annotation inspection queries on location ANNOTATION
🐛 Add rules for annotation inspection queries on location ANNOTATION
Jul 30, 2024
aufi
approved these changes
Aug 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
jmle
force-pushed
the
annotation-inspection-on-annotations
branch
from
August 30, 2024 14:43
0a49bf6
to
1325b2c
Compare
Signed-off-by: Juan Manuel Leflet Estrada <jleflete@redhat.com>
Waiting for CI to be green |
pranavgaikwad
approved these changes
Sep 4, 2024
eemcmullan
approved these changes
Sep 12, 2024
This was referenced Oct 1, 2024
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.