✨ Add Discovery addons and tasks #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mansam
force-pushed
the
discovery-addons
branch
7 times, most recently
from
5cb73f3 to
157f89b
Compare
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
dymurray
requested changes
Jun 21, 2024
| kind: Extension | ||
| apiVersion: tackle.konveyor.io/v1alpha2 | ||
| metadata: | ||
| name: {{ tech_discovery_provider_java_name }} |
There was a problem hiding this comment.
This is undefined, so the deployment errors out
There was a problem hiding this comment.
tech_discovery_provider_generic_name too
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
dymurray
approved these changes
Jun 21, 2024
This was referenced Jun 22, 2024
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also:
konveyor/tackle2-addon-analyzer#99
konveyor/tackle2-hub#671