-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add support for verbosity. #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good other than the replace
go.mod
Outdated
@@ -14,6 +14,8 @@ require ( | |||
k8s.io/utils v0.0.0-20220728103510-ee6ede2d64ed | |||
) | |||
|
|||
replace github.com/konveyor/tackle2-addon => github.com/jortel/tackle2-addon v0.0.0-20231208142659-c1c71f08ffcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unintentional/just for testing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for testing. Will fix with command after konveyor/tackle2-addon#49 is merged.
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Add support for verbosity. This mainly applies to reporting in task activity.
When requested, the command output is included (live) in the activity log. This provides more detail and better insight into what the command is doing currently.
Requires:
closes #61