Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fixing up the addon to use the updated location for bin #80

Merged
merged 2 commits into from
Mar 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cmd/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type Analyzer struct {
// Run analyzer.
func (r *Analyzer) Run() (b *builder.Issues, err error) {
output := path.Join(Dir, "report.yaml")
cmd := command.New("/usr/bin/konveyor-analyzer")
cmd := command.New("/usr/local/bin/konveyor-analyzer")
cmd.Options, err = r.options(output)
if err != nil {
return
Expand Down Expand Up @@ -79,7 +79,7 @@ type DepAnalyzer struct {
// Run analyzer.
func (r *DepAnalyzer) Run() (b *builder.Deps, err error) {
output := path.Join(Dir, "deps.yaml")
cmd := command.New("/usr/bin/konveyor-analyzer-dep")
cmd := command.New("/usr/local/bin/konveyor-analyzer-dep")
cmd.Options, err = r.options(output)
if err != nil {
return
Expand Down
4 changes: 2 additions & 2 deletions hack/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ Set environment variables:
- The `TOKEN` must be set when auth is enabled in the hub.

The addon runs analyzer (CLI) commands:
- /usr/bin/konveyor-analyzer
- /usr/bin/konveyor-analyzer-dep
- /usr/local/bin/konveyor-analyzer
- /usr/local/bin/konveyor-analyzer-dep

These commands have dependencies that can be complicated to install and
most developers won't want to install them in their development environment.
Expand Down
2 changes: 1 addition & 1 deletion hack/konveyor-analyzer
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ do
done

docker run \
--entrypoint konveyor-analyzer \
--entrypoint /usr/local/bin/konveyor-analyzer \
-v ${addon}:${addon} \
${image} \
"${params[@]}"
Expand Down
2 changes: 1 addition & 1 deletion hack/konveyor-analyzer-dep
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ do
params+=("$p")
done
docker run \
--entrypoint /usr/bin/konveyor-analyzer-dep \
--entrypoint /usr/local/bin/konveyor-analyzer-dep \
-v ${addon}:${addon} \
${image} \
"${params[@]}"
Expand Down
4 changes: 2 additions & 2 deletions settings.json
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
[
{
"name": "go",
"binaryPath": "/usr/bin/generic-external-provider",
"binaryPath": "/usr/local/bin/generic-external-provider",
"initConfig": [
{
"analysisMode": "full",
"providerSpecificConfig": {
"name": "go",
"lspServerPath": "/root/go/bin/gopls",
"dependencyProviderPath": "/usr/bin/golang-dependency-provider"
"dependencyProviderPath": "/usr/local/bin/golang-dependency-provider"
}
}
]
Expand Down
Loading