✨ Add raw methods for error and activity reporting by addons. #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add raw methods used by addons to report both errors and activity. The reason is to reduce the number of API calls when reporting large numbers.
For example, the addon.command package reports stdout/stderr for failed commands which can be hundreds (or thousands of lines). Calling Activity() hundreds of times result in hundreds of API calls.
Another example is the reported analyzer errors.
Another aspect is to formalize multi-line activity. This PR codifies the convention of:
and, simplifies the API.
The tackle2-addon command package will need to be updated once this merges to use RawActivity() for stdout/stderr. reporting.
The tackle2-addon-analyzer will need to updated to use both methods in select places as well.