✨ Surface assessment tags on Archetype resource #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mansam
commented
Oct 3, 2023
•
mansam
commented
- Use TagRefs on the Archetype resource
- Add virtual tags inherited from assessments to the Tags field on the Archetype resource
- Fixed a bug where an application would be denied membership in an archetype that wasn't a strict subset of another archetype.
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
changed the title
jortel
reviewed
Oct 4, 2023
api/archetype.go
Outdated
| @@ -331,6 +345,7 @@ type Archetype struct { | |||
| Comments string `json:"comments" yaml:"comments"` | |||
| Tags []Ref `json:"tags" yaml:"tags"` | |||
| CriteriaTags []Ref `json:"criteriaTags" yaml:"criteriaTags"` | |||
| AssessmentTags []Ref `json:"assessmentTags" yaml:"assessmentTags"` | |||
There was a problem hiding this comment.
Why not use TagRef for Tags and differentiate then based on source like applications? I assume they are virtual tags?
Signed-off-by: Sam Lucidi <slucidi@redhat.com>
mansam
force-pushed
the
archetype-assessment-tags
branch
from
a5d18f9 to
1a5f19f
Compare
1 task
This was referenced Nov 22, 2023
This was referenced Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.