Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add yaml:"inline" to Resource field tags #543

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

mansam
Copy link
Collaborator

@mansam mansam commented Oct 26, 2023

The yaml encoder/decoder needs to be explicitly told inline the Resource struct's fields on each of the API resources, otherwise attempts to bind requests that include Resource fields (id, createTime, createUser, updateUser) fail.

@mansam mansam requested a review from jortel October 26, 2023 16:24
@mansam mansam changed the title Add yaml:"inline" to Resource field tags 🐛 Add yaml:"inline" to Resource field tags Oct 26, 2023
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
@mansam mansam merged commit 66b56b5 into konveyor:main Oct 27, 2023
11 checks passed
aufi pushed a commit to aufi/tackle2-hub that referenced this pull request Oct 30, 2023
The yaml encoder/decoder needs to be explicitly told inline the
`Resource` struct's fields on each of the API resources, otherwise
attempts to bind requests that include Resource fields (`id`,
`createTime`, `createUser`, `updateUser`) fail.

Signed-off-by: Sam Lucidi <slucidi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants