Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix yaml task data #549

Merged
merged 4 commits into from
Nov 3, 2023
Merged

🐛 Fix yaml task data #549

merged 4 commits into from
Nov 3, 2023

Conversation

jortel
Copy link
Contributor

@jortel jortel commented Nov 2, 2023

Fix JSON encoding of resources fields of type any.
When the content-type is YAML, the decoded resource fields of type any will be unmarshalled as map[any]any. This is legal for YAML but not JSON. As a result, the JSON encoding fails and the field value is NOT stored.

Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
@jortel jortel changed the title Fix yaml task data 🐛 Fix yaml task data Nov 2, 2023
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Copy link
Member

@aufi aufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mansam mansam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants