🌱 If seed dir exists on the filesystem, don't clone it in the dockerfile #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianvf
changed the title
|
The failing test is from ruleset changes that have broken CI, unrelated to this PR (this PR is the first step to gating that repo so we stop getting breakages) |
shawn-hurley
approved these changes
Dec 12, 2023
jortel
reviewed
Dec 13, 2023
| RUN git clone --branch ${SEED_BRANCH} https://github.com/${SEED_PROJECT} | ||
| RUN if [ ! -d "/opt/app-root/src/tackle2-seed" ]; then \ | ||
| git clone --branch ${SEED_BRANCH} https://github.com/${SEED_PROJECT} /opt/app-root/src/tackle2-seed; \ | ||
| fi |
There was a problem hiding this comment.
Perhaps a var for the seed root directory would be better to ensure it's the same everywhere.
Like:
ARG SEED_ROOT=/opt/app-root/src/tackle2-seed
RUN if [ ! -d "${SEED_ROOT}" ]; then \
git clone --branch ${SEED_BRANCH} https://github.com/${SEED_PROJECT} ${SEED_ROOT}; \
fi
Then below:
COPY --from=builder ${SEED_ROOT}/resources/ /tmp/seed
Signed-off-by: Fabian von Feilitzsch <fabian@fabianism.us>
fabianvf
force-pushed
the
allow-seed-dir
branch
from
6bb4477 to
b95641c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the simplest way to do it I think, without requiring Makefile updates to pass along build-args and dealing with various values. If you just drop tackle2-seed into the project it won't clone it anymore.