✨ Support task addon succeeded with errors. #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jeff Ortel <jortel@redhat.com>
Signed-off-by: Jeff Ortel <jortel@redhat.com>
mansam
approved these changes
Jul 2, 2024
shawn-hurley
added a commit
that referenced
this pull request
Jul 3, 2024
This reverts commit 4648a9c.
dymurray
pushed a commit
that referenced
this pull request
Jul 3, 2024
This was referenced Jul 10, 2024
jortel
added a commit
to konveyor/tackle2-addon-analyzer
that referenced
this pull request
Jul 10, 2024
Errors listed by the analyzer in the report (errors array) are reported by the addon as TaskReport errors but the TaskReport.Status is not set to `Failed`. Requires: konveyor/tackle2-hub#681 --------- Signed-off-by: Jeff Ortel <jortel@redhat.com>
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support an addon reporting errors independently of reporting state=Failed.