Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add GetMultiple function to fetch multiple tasks by IDs #760

Closed
wants to merge 7 commits into from

Conversation

MiriSafra
Copy link

@MiriSafra MiriSafra commented Oct 27, 2024

Implemented the GetMultiple function in TaskHandler to retrieve multiple tasks based on provided IDs, process the task data, and return a formatted response
related tackle2-ui PR #2142

MiriSafra and others added 7 commits October 27, 2024 13:38
Signed-off-by: MiriSafra <m0533175827@gmail.com>
Signed-off-by: shevijacobson <shevijacob@gmail.com>
Add function to retrieve multiple tasks by their IDs
Signed-off-by: MiriSafra <m0533175827@gmail.com>
…tiple function

Signed-off-by: shevijacobson <shevijacob@gmail.com>
Enhance GetMultiple handler with task response formatting
Signed-off-by: MiriSafra <m0533175827@gmail.com>
Copy link
Contributor

@jortel jortel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this PR is necessary.
The hub /tasks endpoint supports filtering.
Example: To fetch task 1,2,3

GET /tasks?filter=id:(1|2|3)

The hub API is RESTful and by convention POST is used to create resources. Queries are support using GET with the filter syntax.

@MiriSafra MiriSafra marked this pull request as draft October 28, 2024 20:52
@MiriSafra
Copy link
Author

In light of @jortel feedback, I will proceed to close the PR. Thank you for your input!

@MiriSafra MiriSafra closed this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants