🐛 Fix running as non-root on vanilla kubernetes #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Montleon <jmontleo@redhat.com>
jortel
approved these changes
Nov 14, 2024
dymurray
pushed a commit
to dymurray/tackle2-hub
that referenced
this pull request
Nov 20, 2024
It looks like running as root is failing on minikube (and probably vanilla kubernetes) because there is no /etc/passwd entry to correspond to the UID. This is the source of the current test failures. golang/go#38599 In a minikube environment the operator runs as UID 1001 and assigns this to the hub as well. My thoughts on this were that we could: - Add a /etc/passwd for uid 1001 to cover the default vanilla kube/minikube scenario - Check in the operator if the operators uid is 1001 and if so set the hub_uid to 0 instead, which I guess mimics the current status quo. - Find a different way to get the UID in go... (no luck so far and I'd guess if there were an option it would have been mentioned on the issue linked above). @jortel also mentioned we could: - Have the hub exec and run id -u instead of os.user.Current(). - If the ansible module in the operator has access to the real uid, it can set the "TASK_UID" env var. I am happy to rework this however we want. Signed-off-by: Jason Montleon <jmontleo@redhat.com> (cherry picked from commit a4c11db)
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like running as root is failing on minikube (and probably vanilla kubernetes) because there is no /etc/passwd entry to correspond to the UID. This is the source of the current test failures.
golang/go#38599
In a minikube environment the operator runs as UID 1001 and assigns this to the hub as well.
My thoughts on this were that we could:
@jortel also mentioned we could:
I am happy to rework this however we want.