✨ Add empty state for empty groups / stakeholders list #1817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibolton336
changed the title
ibolton336
force-pushed
the
sh-g-empty-fix
branch
from
67f2236 to
04e1487
Compare
ibolton336
force-pushed
the
sh-g-empty-fix
branch
2 times, most recently
from
118f0cb to
226ff5a
Compare
Signed-off-by: Ian Bolton <ibolton@redhat.com>
ibolton336
force-pushed
the
sh-g-empty-fix
branch
from
226ff5a to
909e4d2
Compare
…biage Signed-off-by: Ian Bolton <ibolton@redhat.com>
ibolton336
force-pushed
the
sh-g-empty-fix
branch
from
909e4d2 to
7849653
Compare
sjd78
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
The Empty state bits LGTM
As @rszwajko pointed out, a bunch of our translations texts are more like string templates than translatable keys. Since this is fairly prevalent across the codebase, I don't consider this a blocking problem. Something to think about what/if we want to do something in future.
ibolton336
added
the
cherry-pick/release-0.3
ibolton336
added a commit
to ibolton336/tackle2-ui
that referenced
this pull request
Apr 10, 2024
Resolves konveyor#1816 <img width="1650" alt="Screenshot 2024-04-04 at 3 25 17 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/b4c3d099-83ee-49e6-b498-0877ddd8caee"> <img width="1647" alt="Screenshot 2024-04-04 at 3 25 06 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/f2d4519d-dcb9-49c8-aab9-e0734d3f322a"> <img width="1654" alt="Screenshot 2024-04-04 at 3 24 59 PM" src="https://github.com/konveyor/tackle2-ui/assets/11218376/5861a412-b1ff-48f6-82d6-410a4a7d1411"> --------- Signed-off-by: Ian Bolton <ibolton@redhat.com>
This was referenced May 8, 2024
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1816
