Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging for ubuntu bionic #2

Open
wants to merge 75 commits into
base: kx-2.4
Choose a base branch
from
Open

Packaging for ubuntu bionic #2

wants to merge 75 commits into from

Conversation

craigds
Copy link
Member

@craigds craigds commented Jan 22, 2020

(no need to actually merge this; it can live as a separate branch for now so we can easily build either branch in CI).

This contains packaging/build changes for ubuntu bionic, for the kx-2.4 branch.

todo

  • re-include libkea once there's a green build (circular deps, fun)

rouault and others added 30 commits October 28, 2019 21:53
…where one band is larger than 2 GB (2.3 regression)
…entification of raw binary formats such as ENVI (fixes OSGeo#1961)
…d falsely return true if the point was aligned with a segment, but not between the nodes. Impact correct reconstruction of holes in shapefile driver
…a items whose value is a list on several lines
…hreaded reads (fixes OSGeo#1244)

Kudos to @tbonfort for the easy reproducer.
…hread which created it (fixes OSGeo#1989). This workarounds a PROJ bug also fixed per OSGeo/PROJ#1726
…SGeo#2011)

When writing several GDAL datasets in parallel from several threads, a
thread can force a dirty block of another thread/dataset to be written. By
doing so, it will remove it from the list of cached blocks, so if the thread
that explictly manipulates this dataset reacquire the block, it will see an
old version of the block. The effect of this can be particularly seen with
GeoTIFF files with multi band pixel leaving organization, where acquiring
a block of a band causes corresponding blocks of other bands to be cached.

The main fix done here is in GDALRasterBlock::Internalize() to avoid evicting
a dirty block of another dataset when there are other candidates. This considerably
reduces the likelihood of the bug.

Another fix is done in GDALDataset::EnterReadWrite() to wait for the completion
of the flushing of pending dirty blocks of the dataset before reading new blocks.

I believe there could still be problems if the block cache size is too
small regarding the number of threads.
… whose content is not a temperature, but a derived quantity, such as spread
@craigds craigds force-pushed the kx-2.4-bionic branch 3 times, most recently from 4db9730 to c49ab23 Compare February 7, 2020 03:03
@craigds craigds requested a review from rcoup February 12, 2020 20:23

# skip known failures
rm gcore/rfc30.py
TRAVIS=YES TRAVIS_BRANCH=trusty pytest -v -k 'not (test_ogr_fgdb_13 or test_vsisync or test_vsis3_init or test_vsis3_1 or test_vsis3_cleanup or test_eedai_GOOGLE_APPLICATION_CREDENTIALS)'
TRAVIS=YES TRAVIS_BRANCH=ubuntu_1804 pytest -v -k 'not (test_ogr_fgdb_13 or test_vsisync or test_vsis3_init or test_vsis3_1 or test_vsis3_cleanup or test_eedai_GOOGLE_APPLICATION_CREDENTIALS)'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we review the not list here based on what actually fails under bionic?

--with-java=/usr/lib/jvm/default-java \
--with-perl \
--with-python \
--with-kea=/usr/bin/kea-config \
--with-jpeg12 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

12-bit jpeg support (jpeg12) is default now?

rcoup and others added 24 commits January 28, 2021 11:44
…pped to the input data-type.

Includes a test

Cherry-picked from ddc8ac0
* Update build config to 2.3.0
* Add extra VSI flags to link GDAL statically. As recommended by https://trac.osgeo.org/gdal/wiki/VSIPreload
* Use aptly-uploader to uplaod to aptly
* Make python[3]-gdal and gdal-bin require exact version of libgdal20
* Remove vsipreload: In libgdal-dev, it conflicts with the old libgdal1h package, which we still need (postgis depends on it). We also don't use it any more.
* CI via buildkite
* Don't strip symbol tables from our debian builds
This fixes an issue where a keep-alive'd connection via a proxy is closed by the server, and subsequent range requests fail because the proxy's headers are treated as the response headers.
In Curl>=7.54 there's an option to suppress passing proxy response headers through to the application, but for older libcurl versions we add a reasonably conservative workaround.
Easier to fake buildkite builds locally
Not the newest, but I got errors building against 8.0.1 and I want a closer-to-trusty version
to make this simpler
We (trusty) used to have it implicitly because libpq-dev depended on it, but it no longer does in bionic.
Bionic packaging removes the rpath from the libraries, but we need it
for our kakadu and filegdb libs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants