-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: support cold memory collect and report #1514
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1514 +/- ##
==========================================
+ Coverage 64.77% 64.90% +0.12%
==========================================
Files 347 349 +2
Lines 35365 35950 +585
==========================================
+ Hits 22908 23333 +425
- Misses 10774 10895 +121
- Partials 1683 1722 +39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cc @zwzhang0107 @hormes @eahydra @jasonliu747 @FillZpp @ZiMengSheng PTAL
@saintube: GitHub didn't allow me to request PR reviews from the following users: PTAL. Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
/lgtm |
@BUPT-wxq As discussed in the bi-weekly meeting, please add a section Observability & Evaluation in the proposal, which describes the metrics about the benefits and overhead of the coldpgs. |
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
/lgtm |
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
docs/proposals/koordlet/20230728-support-cold-memory-compute.md
Outdated
Show resolved
Hide resolved
Signed-off-by: BUPT-wxq <1725712048@qq.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hormes The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test