Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: support cold memory collect and report #1514

Merged
merged 30 commits into from
Aug 15, 2023

Conversation

BUPT-wxq
Copy link
Contributor

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.12% 🎉

Comparison is base (e860f15) 64.77% compared to head (a935e73) 64.90%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
+ Coverage   64.77%   64.90%   +0.12%     
==========================================
  Files         347      349       +2     
  Lines       35365    35950     +585     
==========================================
+ Hits        22908    23333     +425     
- Misses      10774    10895     +121     
- Partials     1683     1722      +39     
Flag Coverage Δ
unittests 64.90% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BUPT-wxq BUPT-wxq changed the title [WIP]support cold memory collect and report [WIP]Proposal: support cold memory collect and report Aug 3, 2023
Copy link
Member

@saintube saintube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koordinator-bot
Copy link

@saintube: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only koordinator-sh members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/lgtm
/cc @zwzhang0107 @hormes @eahydra @jasonliu747 @FillZpp @ZiMengSheng PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
@hormes
Copy link
Member

hormes commented Aug 9, 2023

/lgtm

@saintube
Copy link
Member

saintube commented Aug 9, 2023

@BUPT-wxq As discussed in the bi-weekly meeting, please add a section Observability & Evaluation in the proposal, which describes the metrics about the benefits and overhead of the coldpgs.

Signed-off-by: BUPT-wxq <1725712048@qq.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Aug 9, 2023
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
Signed-off-by: BUPT-wxq <1725712048@qq.com>
@saintube
Copy link
Member

/lgtm

@koordinator-bot koordinator-bot bot added the lgtm label Aug 11, 2023
Signed-off-by: BUPT-wxq <1725712048@qq.com>
@koordinator-bot koordinator-bot bot removed the lgtm label Aug 14, 2023
@hormes hormes added this to the v1.4 milestone Aug 15, 2023
@hormes
Copy link
Member

hormes commented Aug 15, 2023

/lgtm
/approve

@koordinator-bot koordinator-bot bot added the lgtm label Aug 15, 2023
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit e67ac5c into koordinator-sh:main Aug 15, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants