-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: report system resource usage in node metric #1538
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #1538 +/- ##
==========================================
+ Coverage 64.78% 64.82% +0.04%
==========================================
Files 347 348 +1
Lines 35376 35592 +216
==========================================
+ Hits 22917 23072 +155
- Misses 10780 10825 +45
- Partials 1679 1695 +16
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Signed-off-by: 佑祎 <zzw261520@alibaba-inc.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FillZpp, saintube The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
Update system usage in node metric crd.
Add system usage collector in metric advisor. Read latest usage of node and pods from share state in context and calculate system usage, then saves in metric cache.
Although this can be calculate by node-sum(pod) from metric cache, but the time series are unaligned across different type of metric, which makes it hard to aggregate.
Ⅱ. Does this pull request fix one issue?
#991
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test