-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koord-manager: add unallocated resource into mid resource. #2152
base: main
Are you sure you want to change the base?
koord-manager: add unallocated resource into mid resource. #2152
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2152 +/- ##
==========================================
+ Coverage 67.72% 67.74% +0.02%
==========================================
Files 446 446
Lines 42695 42744 +49
==========================================
+ Hits 28916 28959 +43
- Misses 11258 11265 +7
+ Partials 2521 2520 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@tan90github BTW, please rebase to the main branch to resolve the E2E issue. |
b459be4
to
f8ba51e
Compare
53fa9af
to
8fc81ec
Compare
8fc81ec
to
a23ae29
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
2bb3466
to
e338456
Compare
All conversations are resolved. PTAL @saintube , thanks. |
917cc60
to
383247d
Compare
/lgtm |
Do you have any other questions about this PR? @zwzhang0107 @jasonliu747 PTAL, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
383247d
to
7a09574
Compare
Signed-off-by: wangyang60 <wangy9834@163.com>
7a09574
to
0abec7a
Compare
After rebase, you may need to re-Approve to merge the PR? Thank you very much! @jasonliu747 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@jasonliu747 thanks for your replay, but it seems that the koordinator-bot did not come to mark the approve label. is it a bug? |
@saintube @jasonliu747 This PR has been Approved for a long time, but it has not been merged. Please remind me when it can be merge and approve after I rebase the code. Thanks! |
@tan90github Since there is an API change in this PR, it requires the approval of the api-machinery OWNER. |
Ⅰ. Describe what this PR does
Ⅱ. Does this pull request fix one issue?
add unallocated resource into mid resource. refer link
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test