Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koord-manager: add unallocated resource into mid resource. #2152

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tan90github
Copy link
Contributor

@tan90github tan90github commented Aug 2, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

add unallocated resource into mid resource. refer link

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

@tan90github
Copy link
Contributor Author

Copy link

codecov bot commented Aug 2, 2024

Codecov Report

Attention: Patch coverage is 94.20290% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (aacf585) to head (0abec7a).

Files with missing lines Patch % Lines
...troller/noderesource/plugins/midresource/plugin.go 93.54% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2152      +/-   ##
==========================================
+ Coverage   67.72%   67.74%   +0.02%     
==========================================
  Files         446      446              
  Lines       42695    42744      +49     
==========================================
+ Hits        28916    28959      +43     
- Misses      11258    11265       +7     
+ Partials     2521     2520       -1     
Flag Coverage Δ
unittests 67.74% <94.20%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube
Copy link
Member

@tan90github BTW, please rebase to the main branch to resolve the E2E issue.

@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch from b459be4 to f8ba51e Compare August 27, 2024 07:27
@koordinator-bot koordinator-bot bot added size/L and removed size/M labels Aug 28, 2024
@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch 3 times, most recently from 53fa9af to 8fc81ec Compare August 30, 2024 09:36
@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch from 8fc81ec to a23ae29 Compare September 2, 2024 03:30
@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zwzhang0107 after the PR has been reviewed.
You can assign the PR to them by writing /assign @zwzhang0107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch 4 times, most recently from 2bb3466 to e338456 Compare September 2, 2024 11:59
@tan90github
Copy link
Contributor Author

All conversations are resolved. PTAL @saintube , thanks.

@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch 3 times, most recently from 917cc60 to 383247d Compare September 4, 2024 06:11
@saintube
Copy link
Member

saintube commented Sep 4, 2024

/lgtm
PTAL /cc @zwzhang0107 @jasonliu747

@tan90github
Copy link
Contributor Author

Do you have any other questions about this PR? @zwzhang0107 @jasonliu747 PTAL, thanks.

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch from 383247d to 7a09574 Compare September 6, 2024 06:02
Signed-off-by: wangyang60 <wangy9834@163.com>
@tan90github tan90github force-pushed the feat-midresource-allocatable-github branch from 7a09574 to 0abec7a Compare September 6, 2024 06:03
@tan90github
Copy link
Contributor Author

After rebase, you may need to re-Approve to merge the PR? Thank you very much! @jasonliu747

Copy link
Member

@jasonliu747 jasonliu747 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tan90github
Copy link
Contributor Author

@jasonliu747 thanks for your replay, but it seems that the koordinator-bot did not come to mark the approve label. is it a bug?

@tan90github
Copy link
Contributor Author

@jasonliu747 thanks for your replay, but it seems that the koordinator-bot did not come to mark the approve label. is it a bug?

@saintube @jasonliu747 This PR has been Approved for a long time, but it has not been merged. Please remind me when it can be merge and approve after I rebase the code. Thanks!

@saintube
Copy link
Member

@tan90github Since there is an API change in this PR, it requires the approval of the api-machinery OWNER.
PTAL /cc @zwzhang0107 @hormes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants