Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: support reservation ignored and nodenumaresource preemption #2163

Conversation

saintube
Copy link
Member

@saintube saintube commented Aug 8, 2024

Ⅰ. Describe what this PR does

  • Support a pod-level API that ignores the reserved resources on nodes during the scheduling.
  • Implement the preemption logic for the NodeNUMAResource plugin.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 61.52074% with 167 lines in your changes missing coverage. Please review.

Project coverage is 67.64%. Comparing base (f7c6414) to head (ed9795d).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
.../scheduler/plugins/nodenumaresource/reservation.go 52.17% 64 Missing and 13 partials ⚠️
pkg/scheduler/plugins/nodenumaresource/preempt.go 78.29% 24 Missing and 4 partials ⚠️
...duler/plugins/nodenumaresource/resource_manager.go 39.39% 18 Missing and 2 partials ⚠️
pkg/scheduler/plugins/deviceshare/reservation.go 50.00% 11 Missing and 3 partials ⚠️
pkg/scheduler/plugins/reservation/plugin.go 28.57% 7 Missing and 3 partials ⚠️
pkg/scheduler/plugins/nodenumaresource/plugin.go 72.72% 7 Missing and 2 partials ⚠️
pkg/scheduler/plugins/reservation/transformer.go 65.00% 2 Missing and 5 partials ⚠️
pkg/scheduler/plugins/reservation/scoring.go 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2163      +/-   ##
==========================================
- Coverage   67.89%   67.64%   -0.25%     
==========================================
  Files         443      445       +2     
  Lines       41984    42522     +538     
==========================================
+ Hits        28506    28765     +259     
- Misses      11022    11238     +216     
- Partials     2456     2519      +63     
Flag Coverage Δ
unittests 67.64% <61.52%> (-0.25%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saintube saintube force-pushed the scheduler-support-reservation-ignored branch from 4052e68 to 331d0de Compare August 8, 2024 12:55
@koordinator-bot koordinator-bot bot added size/XL and removed size/L labels Aug 8, 2024
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch from 374727d to d2867ba Compare August 14, 2024 08:30
@saintube saintube changed the title scheduler: support reservation ignored scheduler: support reservation ignored and nodenumaresource preemption Aug 14, 2024
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch from d2867ba to b6dfe9b Compare August 14, 2024 10:33
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch 3 times, most recently from 7735305 to 25ed3f1 Compare August 16, 2024 09:48
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch 2 times, most recently from dcc2c35 to 3fb1304 Compare August 22, 2024 06:23
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch from 3fb1304 to 7f664ec Compare August 29, 2024 09:32
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch from ec0bd71 to 9c86c81 Compare August 29, 2024 11:25
Signed-off-by: saintube <saintube@foxmail.com>
@saintube saintube force-pushed the scheduler-support-reservation-ignored branch from 9c86c81 to ed9795d Compare August 29, 2024 11:52
@ZiMengSheng
Copy link
Contributor

/lgtm

@ZiMengSheng
Copy link
Contributor

Excellent!

@ZiMengSheng
Copy link
Contributor

/approve

@koordinator-bot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hormes, ZiMengSheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@koordinator-bot koordinator-bot bot merged commit 37c8ede into koordinator-sh:main Sep 2, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants