Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

koordlet: support change pod CPUQOS by annotations #2206

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

j4ckstraw
Copy link
Contributor

@j4ckstraw j4ckstraw commented Sep 12, 2024

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

Ⅲ. Describe how to verify it

Ⅳ. Special notes for reviews

V. Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests
  • All checks passed in make test

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.27%. Comparing base (0466bf3) to head (91c0b68).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...et/runtimehooks/hooks/groupidentity/interceptor.go 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2206      +/-   ##
==========================================
- Coverage   67.18%   66.27%   -0.92%     
==========================================
  Files         451      453       +2     
  Lines       43480    53188    +9708     
==========================================
+ Hits        29214    35250    +6036     
- Misses      11718    15397    +3679     
+ Partials     2548     2541       -7     
Flag Coverage Δ
unittests 66.27% <76.92%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zwzhang0107
Copy link
Contributor

seems we need some UT for this

@j4ckstraw j4ckstraw force-pushed the feat/tune-cpuqos-by-annotation branch 2 times, most recently from 45c7bd2 to 2c207ae Compare September 25, 2024 11:57
@j4ckstraw j4ckstraw force-pushed the feat/tune-cpuqos-by-annotation branch from 2c207ae to 6c0835e Compare October 8, 2024 07:31
@j4ckstraw j4ckstraw force-pushed the feat/tune-cpuqos-by-annotation branch 2 times, most recently from c83cd19 to 6a3c355 Compare October 22, 2024 12:11
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
@j4ckstraw j4ckstraw force-pushed the feat/tune-cpuqos-by-annotation branch from 6a3c355 to 91c0b68 Compare October 23, 2024 02:24
@saintube saintube changed the title feat: support change pod CPUQOS by annotations koordlet: support change pod CPUQOS by annotations Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants