Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Get fulltext" should check the file URL #568

Closed
koppor opened this issue May 20, 2022 · 2 comments · Fixed by JabRef/jabref#9437
Closed

"Get fulltext" should check the file URL #568

koppor opened this issue May 20, 2022 · 2 comments · Fixed by JabRef/jabref#9437

Comments

@koppor
Copy link
Member

koppor commented May 20, 2022

We have two buttons at a file

  • "Get fulltext"
    grafik
  • "Download from URL"
    image

Some more "magic" should happen if the URL is pre-filled.

Regarding "Get fulltext": If the URL field is filled AND the URL is reachable AND the returned file is PDF, then this file should be used.

Regarding "Download from URL":

Example:

@Article{Loesch2006,
  author    = {Felix Loesch},
  journal   = {Softwaretechnik-Trends},
  title     = {A Formal Method to Identify Variation Points in Product Line Assets},
  year      = {2006},
  number    = {2},
  volume    = {26},
  bibsource = {dblp computer science bibliography, https://dblp.org},
  biburl    = {https://dblp.org/rec/journals/stt/Loesch06.bib},
  timestamp = {Thu, 12 Mar 2020 11:24:46 +0100},
  url       = {https://pi.informatik.uni-siegen.de/stt/26_2/01_Fachgruppenberichte/04-WSR2006/24-Loesch.pdf},
}
@koppor
Copy link
Member Author

koppor commented Jun 25, 2022

Workaround: right glick on the http link - then "Download file" appears

grafik

This was not intuitive for me, because "from URL" in "Download from URL" could also mean the URL of the currently shown file line.

Idea: Put the link as initial value in the dialog opening

@ThiloteE ThiloteE moved this to Free to take in Good First Issues Oct 14, 2022
@koppor
Copy link
Member Author

koppor commented Oct 30, 2022

Refs #535 somehow even if the functionality is different.

@koppor koppor moved this from Free to take to Reserved in Good First Issues Nov 10, 2022
@NiD133 NiD133 mentioned this issue Dec 7, 2022
6 tasks
@koppor koppor changed the title Download file should check the file URL "Get fulltext" should check the file URL Dec 8, 2022
@koppor koppor moved this from Reserved to In Progress in Good First Issues Jan 4, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Good First Issues Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant