Distinguish between touch and non-touch pointer events #1608
Conversation
|
As written wouldn't the slot 0 is_finger state simply swap between true and false a bit? |
|
That one only changes on a |
| @@ -423,7 +424,7 @@ function S.waitForEvent(sec, usec) | |||
| end | |||
| local x = is_finger and event.tfinger.x * S.w or event.button.x | |||
| local y = is_finger and event.tfinger.y * S.h or event.button.y | |||
| setPointerDownState(slot, true) | |||
| setPointerDownState(slot, true, is_finger) | |||
There was a problem hiding this comment.
Oh right, in the specific sway bug scenario this one will only trigger once. But in that case this would need a lot of comments to explain what it's doing since this won't solve the generic scenario that a naive reader would expect to be solved.
There was a problem hiding this comment.
Yeah, more comments would be good; because that MOUSEMOTION event in the middle of the sandwich is hella weird ;o).
(I wouldn't mind a link to koreader/koreader#10417 (comment) in said comment, as this clearly showcases the issue).
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
|
Yeah, that looks sensible to me ;). |
|
This PR should become unnecessary once swaywm/sway#7583 gets accepted. |
|
Alright, let's wait and see a bit. |
|
swaywm/sway#7583 has been merged, rendering this PR unnecessary. |
Fixes koreader/koreader#10417.
This change is