rfc 5861 (stale-if-error, stale-while-revalidate) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
stale-if error works fine in cacheable-request https://github.com/lukechilds/cacheable-request/issues/94. Without changing the code. I have created a test case locally. |
kornelski
reviewed
Feb 26, 2020
|
Sorry, GitHub UI is stupid and I didn't notice that my comments weren't public yet |
added 2 commits
February 27, 2020 09:50
|
I also added an easy way to mock time. Tests were randomly breaking otherwise. |
|
Please don't add unrelated functionality to a PR. I don't like the mocking change. The |
|
I have reverted the mock. I missed to realise that there was already a way. Thanks for spotting that! I had to monkey patch |
kornelski
changed the title
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #27