Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle non-fatal errors on SSLRead #183

Merged
merged 3 commits into from
May 16, 2023

Conversation

ragoso
Copy link
Contributor

@ragoso ragoso commented May 16, 2023

From #182

Based on curl's solution on this issue and PR

@ragoso ragoso changed the title handle non-fatal errors on SSLRead too handle non-fatal errors on SSLRead May 16, 2023
@kornelski
Copy link
Owner

kornelski commented May 16, 2023

I'm worried about continuing on errSSLWouldBlock. You get this with non-blocking sockets, so next read will very likely return the same error, and since you're calling read recursively, this can blow up the stack (and if it didn't, it'd be busy-looping).

@ragoso
Copy link
Contributor Author

ragoso commented May 16, 2023

I'm worried about continuing on errSSLWouldBlock. You get this with non-blocking sockets, so next read will very likely return the same error, and since you're calling read recursively, this can blow up the stack (and if it didn't, it'd be busy-looping).

You're right, let's just stop at the root cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants