Skip to content
This repository has been archived by the owner on Nov 9, 2017. It is now read-only.

Use turbolinks 5 events #59

Closed
wants to merge 2 commits into from
Closed

Conversation

dsandstrom
Copy link

Changed:

  • page:load to turbolinks:load
  • page:fetch to turbolinks:request-start

Fixes #56

I'll update the tests if this gem is not getting deprecated.

Darrell Sandstrom added 2 commits March 25, 2016 11:22
Turbolinks now uses `turbolinks:load` and `turbolinks:request-start`
@kossnocorp
Copy link
Owner

Please see #56 (comment)

TL;DR: I'm looking for a new project owner.

@kossnocorp
Copy link
Owner

I just realized that tests are green 😉. WDYT about #58?

@rstacruz
Copy link
Collaborator

Neat, but I think it should detect which Turbolinks.VERSION you're using first. Also, like @kossnocorp said, what do you think of #58? It has the exact same lines you did here, plus updated tests.

@dsandstrom
Copy link
Author

I swear that wasn't up when I made this PR. Yeah, if that one works, close this one.

@kossnocorp
Copy link
Owner

@dsandstrom thanks!

@kossnocorp kossnocorp closed this Mar 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants