Replace rouille by hyper

[BenoitZugmeyer]

Following #49 discussion, here is a first PR to support auto-reload with WebSockets. It only replaces rouille by hyper. I tried to keep the same logic as much as possible.

I initially wanted to use hyper-staticfile, but there is some issues:

• it doesn't handle mime types
• it doesn't compile with the latest futures crate (because of Consider removing .boxed() combinators and the Box aliases rust-lang/futures-rs#228 )
• because it resolves the file location itself, rethinking the whole cargo-web artifacts logic would be too much changes for this PR.

Instead, I based the file streaming on the Hyper guide. But still, it's a project to consider.

Note: you are using a different code style than mine (especially on spaces inside brackets and parens). Would you mind commiting a rustfmt configuration file reflecting your tastes so it'd be easier for other folks to contribute? See this configuration value in particular.

[koute]

This doesn't belong here; BuildArgs is for shared arguments related to building, so please move it back. (:

[koute]

Right now the StaticDirectory handling doesn't indeed use the key, but that will change in the future once I'll make potential static directory paths configurable, so please revert this change.

[koute]

Could you move those http server related utils to a separate file?

[koute]

Could you perhaps wrap the hyper-related stuff in an simple interface similar to rouille, put that in a separate file (along with the stuff you've added to utils.rs), and then use it here? I really like how simple rouille is and how straightforward its interface is, so I'd love to keep it if possible. (Also, if we decide to switch to something else in the future or refactor how the HTTP server itself works having only one place where it's all located would be nice.)

[koute]

Please remove the Cargo.lock changes. I always update it in a separate commit before bumping up the version.

[koute]

Note: you are using a different code style than mine (especially on spaces inside brackets and parens). Would you mind commiting a rustfmt configuration file reflecting your tastes so it'd be easier for other folks to contribute?

That's something I was planning to do since quite some time, however the problem is that (last time I've checked) rustfmt isn't configurable enough to precisely support my style, which means before I can do that I'd have to contribute to rustfmt first adding the configurability I'd need. So for now I just let everyone use whatever style they want with the intent to clean it up in the future.

because it resolves the file location itself, rethinking the whole cargo-web artifacts logic would be too much changes for this PR.

That's something I wouldn't want to do anyway (if you look in the commit history it actually used to be that the server itself searched for the artifacts!) - I want the embedded server to act as a thin layer serving the file blobs, and pretty much do nothing else. Locating files, reading them, and all of the routing I want to do myself, mostly to be able to reuse as much logic as possible for deploy subcommand etc.

[BenoitZugmeyer]

Ok I did most of what you asked. The only thing I couldn't do is creating an abstraction on hyper types, to be as simple as rouille. I almost got it working, but I'm blocked in the test_chromium module, I cannot figure out how to retrieve the bound port. You can look at it here: master...BenoitZugmeyer:hyper_simple

[koute]

Hmm... can't you just move the Http::new().bind( address, move || Ok( SimpleService { handler: &handler } ) ) part to new (which would make the API just like in rouille)? Then save the Server in Self, and expose local_addr.

[BenoitZugmeyer]

I'm still working on it. Storing the hyper::Server would be nice but because of the closure, I can't find a way to express the type of this value. I think the impl Trait feature would help, but that's not in rust stable yet.

[koute]

Can't you Box it?

[BenoitZugmeyer]

PR updated, with boxed closures! The diff is much smaller, so I made a single commit.

[koute]

This looks great now! Thanks a lot!

One last thing I'd like to request before I merge it - could you add cache control headers like those here?

[BenoitZugmeyer]

Done!

[koute]

Awesome! Thanks a lot!