Don't Sleep(1) in some spin-wait loops (Fx)

Fx counterpart to dotnet/coreclr#21722
kouvel · Dec 30, 2018 · e2280d7 · e2280d7
1 parent 151a606
commit e2280d7
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/src/System.Collections.Concurrent/src/System/Collections/Concurrent/BlockingCollection.cs b/src/System.Collections.Concurrent/src/System/Collections/Concurrent/BlockingCollection.cs
@@ -468,7 +468,7 @@ private bool TryAddWithNoTimeValidation(T item, int millisecondsTimeout, Cancell
                         Debug.Assert((observedAdders + 1) <= (~COMPLETE_ADDING_ON_MASK), "The number of concurrent adders thread exceeded the maximum limit.");
                         break;
                     }
-                    spinner.SpinOnce();
+                    spinner.SpinOnce(sleep1Threshold: -1);
                 }
 
                 // This outer try/finally to workaround of repeating the decrement adders code 3 times, because we should decrement the adders if:
@@ -1506,7 +1506,7 @@ public void CompleteAdding()
                     CancelWaitingProducers();
                     return;
                 }
-                spinner.SpinOnce();
+                spinner.SpinOnce(sleep1Threshold: -1);
             }
         }
 

diff --git a/src/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentStack.cs b/src/System.Collections.Concurrent/src/System/Collections/Concurrent/ConcurrentStack.cs
@@ -384,7 +384,7 @@ private void PushCore(Node head, Node tail)
             // Keep trying to CAS the existing head with the new node until we succeed.
             do
             {
-                spin.SpinOnce();
+                spin.SpinOnce(sleep1Threshold: -1);
                 // Reread the head and link our new node.
                 tail._next = _head;
             }
@@ -645,7 +645,7 @@ private int TryPopCore(int count, out Node poppedHead)
                 // We failed to CAS the new head.  Spin briefly and retry.
                 for (int i = 0; i < backoff; i++)
                 {
-                    spin.SpinOnce();
+                    spin.SpinOnce(sleep1Threshold: -1);
                 }
 
                 if (spin.NextSpinWillYield)

diff --git a/src/System.Threading/src/System/Threading/Barrier.cs b/src/System.Threading/src/System/Threading/Barrier.cs
@@ -387,7 +387,7 @@ public long AddParticipants(int participantCount)
                     }
                     break;
                 }
-                spinner.SpinOnce();
+                spinner.SpinOnce(sleep1Threshold: -1);
             }
             return newPhase;
         }
@@ -472,7 +472,7 @@ public void RemoveParticipants(int participantCount)
                         break;
                     }
                 }
-                spinner.SpinOnce();
+                spinner.SpinOnce(sleep1Threshold: -1);
             }
         }
 
@@ -674,7 +674,7 @@ public bool SignalAndWait(int millisecondsTimeout, CancellationToken cancellatio
                     break;
                 }
 
-                spinner.SpinOnce();
+                spinner.SpinOnce(sleep1Threshold: -1);
             }
 
             // ** Perform the real wait **
@@ -740,7 +740,7 @@ public bool SignalAndWait(int millisecondsTimeout, CancellationToken cancellatio
                         else
                             return false;
                     }
-                    spinner.SpinOnce();
+                    spinner.SpinOnce(sleep1Threshold: -1);
                 }
             }
 

diff --git a/src/System.Threading/src/System/Threading/CountdownEvent.cs b/src/System.Threading/src/System/Threading/CountdownEvent.cs
@@ -247,7 +247,7 @@ public bool Signal(int signalCount)
                 }
 
                 // The CAS failed.  Spin briefly and try again.
-                spin.SpinOnce();
+                spin.SpinOnce(sleep1Threshold: -1);
             }
 
             // If we were the last to signal, set the event.
@@ -361,7 +361,7 @@ public bool TryAddCount(int signalCount)
                 }
 
                 // The CAS failed.  Spin briefly and try again.
-                spin.SpinOnce();
+                spin.SpinOnce(sleep1Threshold: -1);
             }
 
             return true;