-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format: support black >=24 #1829
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1829 +/- ##
=======================================
Coverage ? 98.98%
=======================================
Files ? 37
Lines ? 4156
Branches ? 968
=======================================
Hits ? 4114
Misses ? 26
Partials ? 16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CodSpeed Performance ReportMerging #1829 will not alter performanceComparing Summary
|
@airwoodix
At least on CI, you can set the version matrix here.
In the distant future, yes. |
@airwoodix We should add a unit test for 24.1.0 or later and skip the existing test when 24.1.0 is installed. |
@koxudaxi awesome, thanks a lot for the fast merge and the tests adjustments! |
Fixes #1821
In black >= 24, string processing requires
--preview
and either all--unstable
features, or explicitly enablingstring_processing
in the unstable features (using--enable-unstable-feature
).There are modifications to the black style between versions 23 and 24, such that the snapshot tests are failing with black 24.1.0. The development dependency is therefore still pinned to version 23.x.y.
@koxudaxi is there a mechanism to test against multiple versions of black (and adapt the snapshots)?
I guess that this code will get reworked or deprecated when #1643 is implemented?