Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): custom_template_dir not passed to data_model_type for OpenAPIScope.Parameters #2166

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

hambergerpls
Copy link
Contributor

When generating OpenAPI Parameters model with custom_template_dir, it uses the default template rather than the customized one. It appears that custom_template_dir is not being passed when instantiating the class.

Copy link

codspeed-hq bot commented Nov 23, 2024

CodSpeed Performance Report

Merging #2166 will not alter performance

Comparing hambergerpls:main (bca53ea) with main (9969bf2)

Summary

✅ 30 untouched benchmarks

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (9969bf2) to head (bca53ea).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #2166   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           38        38           
  Lines         4276      4276           
  Branches       986       986           
=========================================
  Hits          4276      4276           
Flag Coverage Δ
unittests 99.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@koxudaxi koxudaxi merged commit a7b0b91 into koxudaxi:main Nov 23, 2024
76 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants