Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Pydantic 2 & additional python versions #414

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Support for Pydantic 2 & additional python versions #414

merged 5 commits into from
Jul 2, 2024

Conversation

jnu
Copy link
Contributor

@jnu jnu commented May 8, 2024 •
edited
Loading

  • Adds more flexible support for other versions of Pydantic and Python, based on options available in datamodel-code-generator.
  • Cleans up some redundant code

fixes #378

woj-i
woj-i approved these changes Jun 17, 2024
View reviewed changes
Copy link

@woj-i woj-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used this branch and it works for me.

@jnu
Copy link
Contributor Author

jnu commented Jun 19, 2024

thanks @woj-i feel free to merge when you want! I don't have write access.

@woj-i
Copy link

woj-i commented Jun 24, 2024

Me neither. I just wanted to let @koxudaxi know I used this branch if he is not convinced it works.

@koxudaxi koxudaxi merged commit 2f41065 into koxudaxi:master Jul 2, 2024
1 check passed
@chantera chantera mentioned this pull request Jul 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woj-i woj-i woj-i approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for pydantic2
3 participants
@jnu @woj-i @koxudaxi