Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info parser #42

Merged
merged 1 commit into from
Nov 1, 2020
Merged

add info parser #42

merged 1 commit into from
Nov 1, 2020

Conversation

akuma5157
Copy link
Contributor

Added small modifications to enable parsing and passing the info block to jinja2 template.
Upstream adds no info, resulting in default FastAPI title on swagger docs page.
Tried running tests, but i'm getting exact same error on my branch as in master......so i guess pass? 😉

@akuma5157
Copy link
Contributor Author

I could not run lint.sh and format.sh as i'm actually coding on my android phone.

Please take the PR as a suggestion to add an info parser if you don't like the edits.. :)

File "/data/data/com.termux/files/usr/lib/python3.9/multiprocessing/synchronize.py", line 30, in <module> raise ImportError("This platform lacks a functioning sem_open" + ImportError: This platform lacks a functioning sem_open implementation, therefore, the required synchronization primitives needed will not function, see issue 3770.

@koxudaxi koxudaxi merged commit c7db469 into koxudaxi:master Nov 1, 2020
@koxudaxi
Copy link
Owner

koxudaxi commented Nov 1, 2020

@akuma5157
Thank you for creating this PR.
looks good!!
I will fix your PR in the master.

Thank you very much 🐱

@akuma5157 akuma5157 deleted the parse-info branch November 2, 2020 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants