Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QR code is not valid by some scanners #105

Closed
BenBeri opened this issue Jan 5, 2022 · 17 comments
Closed

QR code is not valid by some scanners #105

BenBeri opened this issue Jan 5, 2022 · 17 comments
Labels
reviewed Temporary label to review all open and closed PR

Comments

@BenBeri
Copy link

BenBeri commented Jan 5, 2022

I have used the example code of facebook looking QR code from the README, I scanned it with my iphone and it worked, however with all andorid phones I've used it could not get the data, I used this online scanner https://pageloot.com/qr-code-scanner and it could not detect it aswell. I used some online QR code generator, scanned it with all phones and it worked everywhere.

I used the Angular example.

Is there an known issue about this?

@Stedioz
Copy link

Stedioz commented Jan 28, 2022

I confirm, android scanners do not recognize the generated qr code.

@jaqarrick
Copy link

@Stedioz @BenBeri 👋 Hi there! Wondering if you are still experiencing issues scanning with Android devices. I tested with an Android device and it seemed to work fine. This was using the React example with the built in scanner on my device. Thanks in advance!

@brianpmaher
Copy link

Any suggestion on qr scanner packages that do work well with these?

@jaqarrick
Copy link

Still no issues with this library and android (and other devices).. I'm wondering how much these inconsistencies have to do with QR functionality itself, meaning that QR codes become less usable / reliable the more styles and adjustments are added. Here are some other reasons a QR code might not work.

@victorbianconi
Copy link

Seems to be an issue with images from my side, and non-square dots. Any idea how we can use images and still get it working?

@KilianB
Copy link
Contributor

KilianB commented Aug 26, 2022

Probably duplicate of #49

KilianB added a commit to KilianB/styled-qr-code that referenced this issue Aug 27, 2022
@KilianB
Copy link
Contributor

KilianB commented Aug 27, 2022

@victorbianconi and @Stedioz can you please check if the below codes are working on your android devices?

The top row are fixed codes and the bottom row are codes generated with this library. I got an npm package release almost ready, just need to write the changelogs and publish it tomorrow.

image

The package can now be installed via npm i styled-qr-code or yarn add styled-qr-code

https://github.com/KilianB/styled-qr-code

@victorbianconi
Copy link

@victorbianconi and @Stedioz can you please check if the below codes are working on your android devices?

The top row are fixed codes and the bottom row are codes generated with this library. I got an npm package release almost ready, just need to write the changelogs and publish it tomorrow.

image

The package can now be installed via npm i styled-qr-code or yarn add styled-qr-code

https://github.com/KilianB/styled-qr-code

The purple one works for me. I'm using the android's scanner app. But the other ones don't work. I figured out it likely has to do with low contrast colors/background color.

@madmacc
Copy link

madmacc commented Sep 19, 2022

I just discovered the same issue and I have this in a production app. Works fine for ios but the Android native camera for all the devices we tested does not work. Google Lens works but that is not available by default for older devices.

Note: Url points to https://cat-bounce.com/

Created with qr-code-styling (does not work)
qr-code-styling-margin-30

Created with qr-code-generator (works fine)
qr-code-generator

I will test the QR codes above and check out the new package.

@madmacc madmacc mentioned this issue Sep 19, 2022
@madmacc
Copy link

madmacc commented Sep 19, 2022

@victorbianconi and @Stedioz can you please check if the below codes are working on your android devices?

The top row are fixed codes and the bottom row are codes generated with this library. I got an npm package release almost ready, just need to write the changelogs and publish it tomorrow.

image

The package can now be installed via npm i styled-qr-code or yarn add styled-qr-code

https://github.com/KilianB/styled-qr-code

The bottom row seems to work but inconsistently, may be the contrast. I will try your fork with a plain square black QR code and see how it goes.

@smappio
Copy link

smappio commented Oct 4, 2022

I just discovered the same issue and I have this in a production app. Works fine for ios but the Android native camera for all the devices we tested does not work. Google Lens works but that is not available by default for older devices.

Note: Url points to https://cat-bounce.com/

Created with qr-code-styling (does not work) qr-code-styling-margin-30

Created with qr-code-generator (works fine) qr-code-generator

I will test the QR codes above and check out the new package.

Both QRcodes work for me and my Android Oppo.

@madmacc
Copy link

madmacc commented Oct 6, 2022

@smappio It appears to only be an issue for Android 8 and possibly earlier.
See #110 and #49

@smappio
Copy link

smappio commented Oct 6, 2022

Yeah, I understand. I've restricted the colors on my side, so that I prevent any lack of contrast and at the moment, no more issue with guys scanning my users ' qrcode. Fyi I restrict colors to the 700/800/900 variants of tailwindcss colors.

@smappio
Copy link

smappio commented Oct 6, 2022

You can try if you want, connect lechapeau.io, create your account (you can delete it after), go to the qrcode tab of your user profile (your "Chapeau" created at sign up). I'd be interested to know if some colors settings are not working with the color restriction and for some devices.

@madmacc
Copy link

madmacc commented Oct 6, 2022

At the moment I am using @HenkVanMaanen's fork https://github.com/sallandpioneers/qr-code-styling and it works well as long as you don't use the rounded dots.
The issues I am concerned about are not related to colours but with a bug in the code generating the QR code.

@smappio
Copy link

smappio commented Oct 6, 2022

Oh ok, sorry. I use the original version on my ends.

@kozakdenys
Copy link
Owner

Hi @BenBeri @brianpmaher @KilianB @jaqarrick @madmacc @victorbianconi @smappio @Stedioz, sorry for leaving you for so long

The fix was released in version v1.7.1 and above.

@kozakdenys kozakdenys added the reviewed Temporary label to review all open and closed PR label Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Temporary label to review all open and closed PR
Projects
None yet
Development

No branches or pull requests

9 participants