Suppress NotFound error logging on delete calls (#4057)

Signed-off-by: Morten Torkildsen <mortent@google.com>
kptdev · Oct 11, 2023 · 0079beb · 0079beb
1 parent be8ac77
commit 0079beb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/porch/pkg/cache/repository.go b/porch/pkg/cache/repository.go
@@ -499,7 +499,9 @@ func (r *cachedRepository) refreshAllCachedPackages(ctx context.Context) (map[re
 				r.id, nn.Namespace, nn.Name)
 			metaPackage, err := r.metadataStore.Delete(ctx, nn, true)
 			if err != nil {
-				klog.Warningf("repo %s: error deleting PkgRevMeta %s: %v", r.id, nn, err)
+				if !apierrors.IsNotFound(err) {
+					klog.Warningf("repo %s: error deleting PkgRevMeta %s: %v", r.id, nn, err)
+				}
 				metaPackage = meta.PackageRevisionMeta{
 					Name:      nn.Name,
 					Namespace: nn.Namespace,

diff --git a/porch/pkg/engine/engine.go b/porch/pkg/engine/engine.go
@@ -878,7 +878,9 @@ func (cad *cadEngine) deletePackageRevision(ctx context.Context, repo repository
 	}
 	if _, err := cad.metadataStore.Delete(ctx, nn, true); err != nil {
 		// If this fails, the CR will be cleaned up by the background job.
-		klog.Warningf("Error deleting PkgRevMeta %s: %v", nn.String(), err)
+		if !apierrors.IsNotFound(err) {
+			klog.Warningf("Error deleting PkgRevMeta %s: %v", nn.String(), err)
+		}
 	}
 
 	sent := cad.watcherManager.NotifyPackageRevisionChange(watch.Deleted, repoPkgRev, pkgRevMeta)