Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add windows binary to goreleaser.yaml #3962

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nadworny
Copy link
Contributor

Support windows binary

@nadworny nadworny requested a review from a team as a code owner May 15, 2023 13:50
@nadworny nadworny requested a review from yuwenma May 15, 2023 13:50
@google-cla
Copy link

google-cla bot commented May 15, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@mortent
Copy link
Contributor

mortent commented May 15, 2023

@nadworny I'm not necessarily against distributing a Windows binary of kpt, but I think we first would have to make sure we have automated tests for Windows. Most of the contributors to kpt doesn't use Windows and don't have easy access to Windows machines for testing during development.

@nadworny
Copy link
Contributor Author

nadworny commented May 15, 2023

hey @mortent , same here (I'm on macOS) ;) but we have just a few Windows users that would like to use it. I also don't have any experience running Windows tests on Github so not sure how to proceed.

@mortent
Copy link
Contributor

mortent commented May 18, 2023

So we haven't had a lot of requests for Windows support for kpt and we do think it will require some work to set up the infrastructure for testing and for making sure features work well on Windows. So we don't really think it is worth setting up the infrastructure for making Windows releases at this point. If you want to use kpt on Windows, you are of course free to build from source and we are happy to accept fixes to improve the way kpt runs on Windows.

But please also add an issue for this and then we can see if we get more interest in supporting Windows. If we do get interest from others, then we can revisit it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants